Skip to content

Commit f88bb67

Browse files
authored
fix: mark readRow requests as unary operations (#1679)
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
1 parent 45ce93b commit f88bb67

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ If you are using Maven without BOM, add this to your dependencies:
4949
If you are using Gradle 5.x or later, add this to your dependencies:
5050

5151
```Groovy
52-
implementation platform('com.google.cloud:libraries-bom:26.10.0')
52+
implementation platform('com.google.cloud:libraries-bom:26.11.0')
5353
5454
implementation 'com.google.cloud:google-cloud-bigtable'
5555
```

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -395,13 +395,13 @@ public <RowT> UnaryCallable<Query, RowT> createReadRowCallable(RowAdapter<RowT>
395395
ReadRowsUserCallable<RowT> readRowCallable =
396396
new ReadRowsUserCallable<>(readRowsCallable, requestContext);
397397

398-
ServerStreamingCallable<Query, RowT> traced =
399-
new TracedServerStreamingCallable<>(
400-
readRowCallable, clientContext.getTracerFactory(), getSpanName("ReadRow"));
398+
ReadRowsFirstCallable<RowT> firstRow = new ReadRowsFirstCallable<>(readRowCallable);
401399

402-
ReadRowsFirstCallable<RowT> firstRow = new ReadRowsFirstCallable<>(traced);
400+
UnaryCallable<Query, RowT> traced =
401+
new TracedUnaryCallable<>(
402+
firstRow, clientContext.getTracerFactory(), getSpanName("ReadRow"));
403403

404-
return firstRow.withDefaultCallContext(clientContext.getDefaultCallContext());
404+
return traced.withDefaultCallContext(clientContext.getDefaultCallContext());
405405
}
406406

407407
/**

0 commit comments

Comments
 (0)