Skip to content

feat: Create new environment variable to toggle directpath scoped to cloud bigtable. #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 8, 2024
Merged

feat: Create new environment variable to toggle directpath scoped to cloud bigtable. #2261

merged 7 commits into from
Jul 8, 2024

Conversation

meeral-k
Copy link
Contributor

@meeral-k meeral-k commented Jun 18, 2024 •
edited
Loading

feat: Create new environment variable to toggle directpath scoped to cloud bigtable.

@meeral-k meeral-k requested review from a team as code owners June 18, 2024 19:05
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Jun 18, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jun 18, 2024
@meeral-k meeral-k mentioned this pull request Jun 20, 2024
Closed
5 tasks
@igorbernstein2 igorbernstein2 mentioned this pull request Jun 25, 2024
Closed
@meeral-k meeral-k requested a review from a team as a code owner June 26, 2024 16:40
@meeral-k meeral-k changed the title Create new cloud bigtable specific environment variable to toggle directpath feat: Create new environment variable to toggle directpath scoped to cloud bigtable. Jun 27, 2024
igorbernstein2
igorbernstein2 reviewed Jun 27, 2024
View reviewed changes
igorbernstein2
igorbernstein2 reviewed Jun 28, 2024
View reviewed changes
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2024
@meeral-k
Copy link
Contributor Author

meeral-k commented Jul 2, 2024 •
edited
Loading

@igorbernstein2

[11:55:20 PDT][ERROR] Timed out waiting for GitHub to return mergeable status for the pull (PR). GitHub is taking too long to compute whether this PR is mergeable. Please retry the build in a few minutes. You can do this by attaching a kokoro:force-run label on your PR.

the tests need to be re-run. I don't see an option to relabel this PR with kokoro:force-run

@rkaregar rkaregar added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 3, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2024
@igorbernstein2 igorbernstein2 merged commit 9062944 into googleapis:main Jul 8, 2024
20 of 21 checks passed
@release-please release-please bot mentioned this pull request Jul 8, 2024
Merged
ron-gal pushed a commit to ron-gal/java-bigtable that referenced this pull request Jul 23, 2024
@meeral-k @ron-gal
feat: Create new environment variable to toggle directpath scoped to …
5880066 
…cloud bigtable. (googleapis#2261)

* mend

* mend

* address code comments

* formatting fix

* fixed pom to set environment variable and not a system property

* tagged myself in todo,added environment variable to directpath ipv4 only profile
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 24, 2024
@release-please
chore(main): release 2.41.0 (#2277)
664e615 
🤖 I have created a release *beep* *boop*
---


## [2.41.0](https://togithub.com/googleapis/java-bigtable/compare/v2.40.0...v2.41.0) (2024-07-24)


### Features

* Add MergeToCell to Mutation APIs ([#2279](https://togithub.com/googleapis/java-bigtable/issues/2279)) ([0ce8a2a](https://togithub.com/googleapis/java-bigtable/commit/0ce8a2a38703233da58208655f41f6e81e03576e))
* Add support for MergeToCell API ([#2258](https://togithub.com/googleapis/java-bigtable/issues/2258)) ([191d15c](https://togithub.com/googleapis/java-bigtable/commit/191d15c5284dbb702e11669931272877bf05f44e))
* Add support for new functions ([#2287](https://togithub.com/googleapis/java-bigtable/issues/2287)) ([dd6583a](https://togithub.com/googleapis/java-bigtable/commit/dd6583a22504385b7a1f7dc91b3bc3d2500ea0c5))
* Create new environment variable to toggle directpath scoped to cloud bigtable. ([#2261](https://togithub.com/googleapis/java-bigtable/issues/2261)) ([9062944](https://togithub.com/googleapis/java-bigtable/commit/9062944610277eb7ae77f395dc79ce94239c5bee))
* Implement ExecuteQuery API for SQL support ([#2280](https://togithub.com/googleapis/java-bigtable/issues/2280)) ([25218e8](https://togithub.com/googleapis/java-bigtable/commit/25218e8cc46f9a51d4b6515afdb8931e574b0bb1))


### Dependencies

* Update dependency com.google.truth.extensions:truth-proto-extension to v1.4.4 ([#2282](https://togithub.com/googleapis/java-bigtable/issues/2282)) ([d00a9e0](https://togithub.com/googleapis/java-bigtable/commit/d00a9e01b2b329f3bae50f48a15692d87ad0f3bf))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
lqiu96 pushed a commit that referenced this pull request Jul 26, 2024
@meeral-k @lqiu96
feat: Create new environment variable to toggle directpath scoped to …
9a7ac88 
…cloud bigtable. (#2261)

* mend

* mend

* address code comments

* formatting fix

* fixed pom to set environment variable and not a system property

* tagged myself in todo,added environment variable to directpath ipv4 only profile
lqiu96 pushed a commit that referenced this pull request Jul 26, 2024
@release-please @lqiu96
chore(main): release 2.41.0 (#2277)
2ad3242 
🤖 I have created a release *beep* *boop*
---


## [2.41.0](https://togithub.com/googleapis/java-bigtable/compare/v2.40.0...v2.41.0) (2024-07-24)


### Features

* Add MergeToCell to Mutation APIs ([#2279](https://togithub.com/googleapis/java-bigtable/issues/2279)) ([0ce8a2a](https://togithub.com/googleapis/java-bigtable/commit/0ce8a2a38703233da58208655f41f6e81e03576e))
* Add support for MergeToCell API ([#2258](https://togithub.com/googleapis/java-bigtable/issues/2258)) ([191d15c](https://togithub.com/googleapis/java-bigtable/commit/191d15c5284dbb702e11669931272877bf05f44e))
* Add support for new functions ([#2287](https://togithub.com/googleapis/java-bigtable/issues/2287)) ([dd6583a](https://togithub.com/googleapis/java-bigtable/commit/dd6583a22504385b7a1f7dc91b3bc3d2500ea0c5))
* Create new environment variable to toggle directpath scoped to cloud bigtable. ([#2261](https://togithub.com/googleapis/java-bigtable/issues/2261)) ([9062944](https://togithub.com/googleapis/java-bigtable/commit/9062944610277eb7ae77f395dc79ce94239c5bee))
* Implement ExecuteQuery API for SQL support ([#2280](https://togithub.com/googleapis/java-bigtable/issues/2280)) ([25218e8](https://togithub.com/googleapis/java-bigtable/commit/25218e8cc46f9a51d4b6515afdb8931e574b0bb1))


### Dependencies

* Update dependency com.google.truth.extensions:truth-proto-extension to v1.4.4 ([#2282](https://togithub.com/googleapis/java-bigtable/issues/2282)) ([d00a9e0](https://togithub.com/googleapis/java-bigtable/commit/d00a9e01b2b329f3bae50f48a15692d87ad0f3bf))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meeral-k @igorbernstein2 @rkaregar @yoshi-kokoro