Skip to content

test: fix samples for reverse scans #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2023
Merged

test: fix samples for reverse scans #1810

merged 1 commit into from
Jun 27, 2023

Conversation

igorbernstein2
Copy link
Contributor

Change-Id: Id03b5105afe609cae61ae84e484b53b1860daf92

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples. labels Jun 27, 2023
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jun 27, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Change-Id: Id03b5105afe609cae61ae84e484b53b1860daf92
@igorbernstein2 igorbernstein2 force-pushed the rev-scans-public-int-tst branch from c20ffde to da295d1 Compare June 27, 2023 16:22
@igorbernstein2 igorbernstein2 changed the title chore: fix samples test test: fix samples for reverse scans Jun 27, 2023
@igorbernstein2
Copy link
Contributor Author

Please note that the samples tests will fail until the next libraries-bom release

@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 27, 2023
@mutianf mutianf merged commit 63d51f1 into main Jun 27, 2023
@mutianf mutianf deleted the rev-scans-public-int-tst branch June 27, 2023 18:41
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants