Skip to content

fix: Add getPageSize() to QueryPaginator #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 2, 2023
Merged

fix: Add getPageSize() to QueryPaginator #1987

merged 4 commits into from
Nov 2, 2023

Conversation

ron-gal
Copy link
Contributor

@ron-gal ron-gal commented Nov 2, 2023 •
edited by mutianf
Loading

BEGIN_COMMIT_OVERRIDE
fix: Add getPageSize() to QueryPaginator
END_COMMIT_OVERRIDE

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@ron-gal ron-gal requested a review from a team as a code owner November 2, 2023 17:41
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Nov 2, 2023
@ron-gal ron-gal mentioned this pull request Nov 2, 2023
Merged
4 tasks
@ron-gal ron-gal changed the title add getPageSize() to QueryPaginator fix: add getPageSize() to QueryPaginator Nov 2, 2023
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Nov 2, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@ron-gal ron-gal changed the title fix: add getPageSize() to QueryPaginator fix: Add getPageSize() to QueryPaginator Nov 2, 2023
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 2, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 2, 2023
@mutianf mutianf changed the title fix: Add getPageSize() to QueryPaginator chore: Add getPageSize() to QueryPaginator Nov 2, 2023
@mutianf mutianf merged commit 42a7e36 into googleapis:main Nov 2, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 2, 2023
@ron-gal ron-gal deleted the add_getPageSize branch November 2, 2023 18:26
@mutianf mutianf changed the title chore: Add getPageSize() to QueryPaginator fix: Add getPageSize() to QueryPaginator Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutianf mutianf mutianf approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ron-gal @mutianf