Skip to content
This repository was archived by the owner on Nov 9, 2023. It is now read-only.

fix: mark Document.Entity.type as REQUIRED in all versions #817

Merged
merged 5 commits into from
May 2, 2022

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Apr 26, 2022

  • Regenerate this pull request now.

fix: remove Document.Entity.bounding_poly_for_demo_frontend from v1beta2

The type field was always required by the backend, so this formally breaking change can likely be accepted without bumping the major version. Field removal is in beta version so can be accepted as well.

PiperOrigin-RevId: 444656928

Source-Link: googleapis/googleapis@a0d4c5c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/d3a3f6dde18ec3721fceba933e4327a7b6dd2c2d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDNhM2Y2ZGRlMThlYzM3MjFmY2ViYTkzM2U0MzI3YTdiNmRkMmMyZCJ9

chore(bazel): update version of Protobuf to v3.20.1
PiperOrigin-RevId: 444328399

Source-Link: googleapis/googleapis@c7ca416

Source-Link: https://github.com/googleapis/googleapis-gen/commit/d61705453a62b3ecda78aa30c192840ebc5a8a90
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDYxNzA1NDUzYTYyYjNlY2RhNzhhYTMwYzE5Mjg0MGViYzVhOGE5MCJ9

PiperOrigin-RevId: 444328399

Source-Link: googleapis/googleapis@c7ca416

Source-Link: https://github.com/googleapis/googleapis-gen/commit/d61705453a62b3ecda78aa30c192840ebc5a8a90
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDYxNzA1NDUzYTYyYjNlY2RhNzhhYTMwYzE5Mjg0MGViYzVhOGE5MCJ9
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner April 26, 2022 01:52
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 26, 2022
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: documentai Issues related to the googleapis/java-document-ai API. labels Apr 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 26, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 26, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Apr 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2022
fix!: remove Document.Entity.bounding_poly_for_demo_frontend from v1beta2

The type field was always required by the backend, so this formally breaking change can likely be accepted without bumping the major version. Field removal is in beta version so can be accepted as well.

PiperOrigin-RevId: 444656928

Source-Link: googleapis/googleapis@a0d4c5c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/d3a3f6dde18ec3721fceba933e4327a7b6dd2c2d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDNhM2Y2ZGRlMThlYzM3MjFmY2ViYTkzM2U0MzI3YTdiNmRkMmMyZCJ9
@gcf-owl-bot gcf-owl-bot bot changed the title chore(bazel): update version of Protobuf to v3.20.1 fix!: mark Document.Entity.type as REQUIRED in all versions Apr 27, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 27, 2022
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Apr 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Apr 27, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2022
@suztomo suztomo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 28, 2022
@suztomo
Copy link
Member

suztomo commented Apr 29, 2022

CLIRR is failing.

[INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ proto-google-cloud-document-ai-v1beta2 ---
[INFO] artifact com.google.api.grpc:proto-google-cloud-document-ai-v1beta2: checking for updates from central
[INFO] Comparing to version: 0.16.3
Error:  6011: com.google.cloud.documentai.v1beta2.Document$Entity: Field BOUNDING_POLY_FOR_DEMO_FRONTEND_FIELD_NUMBER has been removed, but it was previously a constant
Error:  7002: com.google.cloud.documentai.v1beta2.Document$Entity: Method 'public com.google.cloud.documentai.v1beta2.BoundingPoly getBoundingPolyForDemoFrontend()' has been removed
Error:  7002: com.google.cloud.documentai.v1beta2.Document$Entity: Method 'public com.google.cloud.documentai.v1beta2.BoundingPolyOrBuilder getBoundingPolyForDemoFrontendOrBuilder()' has been removed
Error:  7002: com.google.cloud.documentai.v1beta2.Document$Entity: Method 'public boolean hasBoundingPolyForDemoFrontend()' has been removed
Error:  7002: com.google.cloud.documentai.v1beta2.Document$Entity$Builder: Method 'public com.google.cloud.documentai.v1beta2.Document$Entity$Builder clearBoundingPolyForDemoFrontend()' has been removed
Error:  7002: com.google.cloud.documentai.v1beta2.Document$Entity$Builder: Method 'public com.google.cloud.documentai.v1beta2.BoundingPoly getBoundingPolyForDemoFrontend()' has been removed
Error:  7002: com.google.cloud.documentai.v1beta2.Document$Entity$Builder: Method 'public com.google.cloud.documentai.v1beta2.BoundingPoly$Builder getBoundingPolyForDemoFrontendBuilder()' has been removed
Error:  7002: com.google.cloud.documentai.v1beta2.Document$Entity$Builder: Method 'public com.google.cloud.documentai.v1beta2.BoundingPolyOrBuilder getBoundingPolyForDemoFrontendOrBuilder()' has been removed
Error:  7002: com.google.cloud.documentai.v1beta2.Document$Entity$Builder: Method 'public boolean hasBoundingPolyForDemoFrontend()' has been removed
Error:  7002: com.google.cloud.documentai.v1beta2.Document$Entity$Builder: Method 'public com.google.cloud.documentai.v1beta2.Document$Entity$Builder mergeBoundingPolyForDemoFrontend(com.google.cloud.documentai.v1beta2.BoundingPoly)' has been removed
Error:  7002: com.google.cloud.documentai.v1beta2.Document$Entity$Builder: Method 'public com.google.cloud.documentai.v1beta2.Document$Entity$Builder setBoundingPolyForDemoFrontend(com.google.cloud.documentai.v1beta2.BoundingPoly)' has been removed
Error:  7002: com.google.cloud.documentai.v1beta2.Document$Entity$Builder: Method 'public com.google.cloud.documentai.v1beta2.Document$Entity$Builder setBoundingPolyForDemoFrontend(com.google.cloud.documentai.v1beta2.BoundingPoly$Builder)' has been removed
Error:  7002: com.google.cloud.documentai.v1beta2.Document$EntityOrBuilder: Method 'public com.google.cloud.documentai.v1beta2.BoundingPoly getBoundingPolyForDemoFrontend()' has been removed
Error:  7002: com.google.cloud.documentai.v1beta2.Document$EntityOrBuilder: Method 'public com.google.cloud.documentai.v1beta2.BoundingPolyOrBuilder getBoundingPolyForDemoFrontendOrBuilder()' has been removed
Error:  7002: com.google.cloud.documentai.v1beta2.Document$EntityOrBuilder: Method 'public boolean hasBoundingPolyForDemoFrontend()' has been removed

It's good that they are all beta packages.

@Neenu1995 Neenu1995 changed the title fix!: mark Document.Entity.type as REQUIRED in all versions fix: mark Document.Entity.type as REQUIRED in all versions May 2, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 2, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2022
@Neenu1995 Neenu1995 added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 2, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit eb329e5 into main May 2, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-copy branch May 2, 2022 16:48
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 2, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request May 24, 2022
🤖 I have created a release *beep* *boop*
---


## [2.5.0](v2.4.3...v2.5.0) (2022-05-19)


### Features

* add build scripts for native image testing in Java 17 ([#1440](https://github.com/googleapis/java-document-ai/issues/1440)) ([#825](#825)) ([382dc66](382dc66))


### Bug Fixes

* mark Document.Entity.type as REQUIRED in all versions ([#817](#817)) ([eb329e5](eb329e5))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.12.0 ([#824](#824)) ([dfd5bd6](dfd5bd6))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to meltsufin/monorepo-experiments that referenced this pull request May 24, 2022
🤖 I have created a release *beep* *boop*
---


## [2.5.0](googleapis/java-document-ai@v2.4.3...v2.5.0) (2022-05-19)


### Features

* add build scripts for native image testing in Java 17 ([#1440](https://github.com/googleapis/java-document-ai/issues/1440)) ([#825](googleapis/java-document-ai#825)) ([7e7088c](googleapis/java-document-ai@7e7088c))


### Bug Fixes

* mark Document.Entity.type as REQUIRED in all versions ([#817](googleapis/java-document-ai#817)) ([48086a2](googleapis/java-document-ai@48086a2))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.12.0 ([#824](googleapis/java-document-ai#824)) ([ea6492e](googleapis/java-document-ai@ea6492e))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: documentai Issues related to the googleapis/java-document-ai API. owl-bot-copy size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants