Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

Conversation

Sita04
Copy link
Contributor

@Sita04 Sita04 commented Dec 22, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@Sita04 Sita04 requested a review from a team as a code owner December 22, 2021 06:51
@generated-files-bot
Copy link

generated-files-bot bot commented Dec 22, 2021

Warning: This pull request is touching the following templated files:

  • .kokoro/presubmit/samples.cfg
  • samples/snippets/pom.xml

@product-auto-label product-auto-label bot added api: securitycenter Issues related to the googleapis/java-securitycenter API. samples Issues that are directly related to samples. labels Dec 22, 2021
@snippet-bot
Copy link

snippet-bot bot commented Dec 22, 2021

gcf-owl-bot bot and others added 11 commits December 22, 2021 06:53
…onfig-samples

# Conflicts:
#	samples/snippets/src/main/java/com/google/cloud/examples/securitycenter/snippets/muteconfig/BulkMuteFindings.java
#	samples/snippets/src/main/java/com/google/cloud/examples/securitycenter/snippets/muteconfig/CreateMuteRule.java
#	samples/snippets/src/main/java/com/google/cloud/examples/securitycenter/snippets/muteconfig/DeleteMuteRule.java
#	samples/snippets/src/main/java/com/google/cloud/examples/securitycenter/snippets/muteconfig/GetMuteRule.java
#	samples/snippets/src/main/java/com/google/cloud/examples/securitycenter/snippets/muteconfig/ListMuteRules.java
#	samples/snippets/src/main/java/com/google/cloud/examples/securitycenter/snippets/muteconfig/SetMuteUnmuteFinding.java
#	samples/snippets/src/main/java/com/google/cloud/examples/securitycenter/snippets/muteconfig/UpdateMuteRule.java
#	samples/snippets/src/test/java/com/google/cloud/examples/securitycenter/snippets/MuteFindingIT.java
@Sita04
Copy link
Contributor Author

Sita04 commented Feb 1, 2022

@shubha-rajan PTAL

@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2022
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 15, 2022
@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2022
@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 22, 2022
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2022
Copy link

@catherinerosesantos catherinerosesantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@Sita04 Sita04 merged commit 05018a5 into main Mar 25, 2022
@Sita04 Sita04 deleted the mute-config-samples branch March 25, 2022 19:53
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 30, 2022
🤖 I have created a release *beep* *boop*
---


### [2.5.3](v2.5.2...v2.5.3) (2022-03-29)


### Documentation

* **samples:** added samples for Mute config ([#719](#719)) ([05018a5](05018a5))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.9.0 ([#791](#791)) ([2d75136](2d75136))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: securitycenter Issues related to the googleapis/java-securitycenter API. owlbot:ignore instruct owl-bot to ignore a PR samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants