Skip to content

fix: make sure to pass selectedFields to tabledata.list method #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2025
Merged

fix: make sure to pass selectedFields to tabledata.list method #1449

merged 3 commits into from
Mar 17, 2025

Conversation

alvarowolfx
Copy link
Contributor

@alvarowolfx alvarowolfx commented Mar 14, 2025 •
edited
Loading

A regression got introduce in PR #1437, where a user informed options.selectedField is deleted and not sent to the tabledata.list API.

Also this PR avoid mutations on the selectedFields parameter across the SDK, which solves other issues reported on #1433. More tests where added to cover cases with array and deeply nested objects.

Fixes #1433

@alvarowolfx alvarowolfx requested review from a team as code owners March 14, 2025 20:32
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Mar 14, 2025
leahecole
leahecole approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but just pin that promisify version for now to fix ci

@alvarowolfx
Copy link
Contributor Author

blocked by #1450

@alvarowolfx alvarowolfx merged commit 206aff9 into main Mar 17, 2025
18 checks passed
@alvarowolfx alvarowolfx deleted the fix-selected-field-mutation branch March 17, 2025 20:01
@release-please release-please bot mentioned this pull request Mar 17, 2025
Merged
This was referenced Mar 25, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in table.getRows when using different selectedFields in consecutive calls
2 participants
@alvarowolfx @leahecole