Skip to content

chore(deps): remove readable-stream #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 2, 2023
Merged

chore(deps): remove readable-stream #1213

merged 5 commits into from
Jun 2, 2023

Conversation

alvarowolfx
Copy link
Contributor

Remove readable-stream as was being used only on system-tests and it can actually be imported from the native streams package.

Fixes #1200 🦕

@alvarowolfx alvarowolfx requested review from a team as code owners June 1, 2023 18:03
@alvarowolfx alvarowolfx requested a review from GaoleMeng June 1, 2023 18:03
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Jun 1, 2023
@alvarowolfx alvarowolfx mentioned this pull request Jun 1, 2023
Closed
@alvarowolfx alvarowolfx added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 1, 2023
@alvarowolfx alvarowolfx added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 1, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 1, 2023
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 1, 2023
@alvarowolfx alvarowolfx requested a review from steffnay June 1, 2023 19:03
ruyadorno
ruyadorno reviewed Jun 1, 2023
View reviewed changes
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Jun 1, 2023
@alvarowolfx alvarowolfx added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 1, 2023
@alvarowolfx alvarowolfx added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 1, 2023
@alvarowolfx alvarowolfx added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 2, 2023
@alvarowolfx alvarowolfx merged commit 4510520 into googleapis:main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

@GaoleMeng GaoleMeng Awaiting requested review from GaoleMeng GaoleMeng is a code owner automatically assigned from googleapis/api-bigquery

@steffnay steffnay Awaiting requested review from steffnay

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consideration of removing an unnecessary dependency.
3 participants
@alvarowolfx @ruyadorno @yoshi-kokoro