Skip to content

chore: update types from Discovery #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2023
Merged

chore: update types from Discovery #1225

merged 2 commits into from
Jul 17, 2023

Conversation

alvarowolfx
Copy link
Contributor

@alvarowolfx alvarowolfx commented Jul 13, 2023 •
edited
Loading

Sync discovery types and handle some internal issues related to adding new fields to Node SDK:

  • Default Value Expression - b/243165219
  • Sessions in Load Jobs - b/268632415
  • Reference File Schema for load/federated queries - b/246810696
  • Remote Function Options - b/249154342
  • searchStatistics - b/290679162

@alvarowolfx alvarowolfx requested review from a team as code owners July 13, 2023 17:28
@alvarowolfx alvarowolfx requested a review from Neenu1995 July 13, 2023 17:28
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Jul 13, 2023
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2023
@alvarowolfx alvarowolfx requested a review from shollyman July 13, 2023 19:23
shollyman
shollyman approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding some details to the PR description about how the generator was invoked?

@alvarowolfx
Copy link
Contributor Author

Mind adding some details to the PR description about how the generator was invoked?

there is a script on the package.json file for that.
npm run types

This uses an external dependency to generate type.d.ts files based on the discovery docs.
https://github.com/callmehiphop/discovery-tsd

@alvarowolfx alvarowolfx merged commit 51fc8c3 into googleapis:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995 Neenu1995 is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvarowolfx @shollyman