Skip to content

feat: Update ExecuteQuery to use Prepare #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 18, 2025
Merged

feat: Update ExecuteQuery to use Prepare #1100

merged 6 commits into from
Mar 18, 2025

Conversation

jackdingilian
Copy link
Contributor

@jackdingilian jackdingilian commented Mar 18, 2025 •
edited
Loading

This updates execute_query to use the new PrepareQuery API and adds support for the most recent protocol updates.
It also removes the preview warning for the API.

This was reviewed in separate PRs:

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@jackdingilian jackdingilian requested review from a team as code owners March 18, 2025 18:21
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/python-bigtable API. labels Mar 18, 2025
daniel-sanche
daniel-sanche approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - reviewed commits independently:

@jackdingilian jackdingilian merged commit 8a7abc1 into main Mar 18, 2025
24 of 32 checks passed
@jackdingilian jackdingilian deleted the prepare-query branch March 18, 2025 20:47
@release-please release-please bot mentioned this pull request Mar 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Assignees

@daniel-sanche daniel-sanche

Labels
api: bigtable Issues related to the googleapis/python-bigtable API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackdingilian @daniel-sanche @kongweihan