Skip to content

feat: Refactor Metadata, add system tests, remove preview warning #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jackdingilian
Copy link
Contributor

Removes ProtoMetadata because all of it's functionality is generic and ok to expose to users (column names and types). The original reason for this was to support other schema types in the future, while hiding them from users. The metadata will always have columns and types though, so this isn't currently necessary

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@jackdingilian jackdingilian requested review from a team as code owners March 18, 2025 16:54
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/python-bigtable API. labels Mar 18, 2025
@jackdingilian jackdingilian changed the title Refactor Metadata, add system tests, remove preview warning feat: Refactor Metadata, add system tests, remove preview warning Mar 18, 2025
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackdingilian jackdingilian merged commit a2151fe into googleapis:prepare-query Mar 18, 2025
7 of 9 checks passed
@jackdingilian jackdingilian deleted the prepare-final-rebase branch March 18, 2025 18:21
jackdingilian added a commit that referenced this pull request Mar 18, 2025
* feat: update execute_query to use PrepareQuery API (#1095)

* feat: Implement updated execute query protocol (#1096)

* feat: Refactor Metadata, add system tests, remove preview warning (#1099)

* Fix  setup.py merge

* fix: skip sql tests for emulator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants