fix: ordering in limit_to_last (#692)

Mariatta · web-flow · commit cc9dfb394744 · 2023-02-21T16:01:35.000-05:00
When limit_to_last was set, we need to reverse the order. However due to error in comparing the order direction, it was not properly set. comparing `order.direction == self.ASCENDING` is always `False` because there are two different types. The correct way is by comparing `order.direction.name == self.ASCENDING` Fixes #536
diff --git a/google/cloud/firestore_v1/query.py b/google/cloud/firestore_v1/query.py
@@ -160,7 +160,7 @@ def get(
             for order in self._orders:
                 order.direction = _enum_from_direction(
                     self.DESCENDING
-                    if order.direction == self.ASCENDING
+                    if order.direction.name == self.ASCENDING
                     else self.ASCENDING
                 )
             self._limit_to_last = False

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ def get(`
`160`	`160`	`for order in self._orders:`
`161`	`161`	`order.direction = _enum_from_direction(`
`162`	`162`	`self.DESCENDING`
`163`		`- if order.direction == self.ASCENDING`
	`163`	`+ if order.direction.name == self.ASCENDING`
`164`	`164`	`else self.ASCENDING`
`165`	`165`	`)`
`166`	`166`	`self._limit_to_last = False`