tests: enable unit tests for Python 3.9 #272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crwilcox
reviewed
Dec 14, 2020
| @@ -71,7 +71,6 @@ | |||
| # ---------------------------------------------------------------------------- | |||
| templated_files = common.py_library( | |||
| samples=False, # set to True only if there are samples | |||
| unit_test_python_versions=["3.6", "3.7", "3.8"], | |||
| system_test_python_versions=["3.7"], | |||
There was a problem hiding this comment.
If we are templating this, your change is going to get overwritten. Should this line be updated not removed?
There was a problem hiding this comment.
The templated change will Do the Right Thing(TM).
There was a problem hiding this comment.
@crwilcox PTAL (if the value is not set, the defaults are correct).
|
closing as latest synths should cover this? |
$ git remote -v
origin [email protected]:googleapis/python-firestore (fetch)
origin [email protected]:googleapis/python-firestore (push)
$ git log -1
commit 403e1ba373c3e92044b926e9365f755c11101289 (HEAD -> master, origin/master, origin/HEAD)
Author: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com>
Date: Fri May 28 16:56:11 2021 +0000
chore: new owl bot post processor docker image (#363)
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:c66ba3c8d7bc8566f47df841f98cd0097b28fff0b1864c86f5817f4c8c3e8600
$ git status
On branch master
Your branch is up to date with 'origin/master'.
nothing to commit, working tree clean
$ nox --list
Sessions defined in /home/tseaver/projects/agendaless/Google/src/python-firestore/noxfile.py:
* lint -> Run linters.
* blacken -> Run black. Format code to uniform standard.
- pytype -> Run pytype
* lint_setup_py -> Verify that setup.py is valid (including RST check).
* unit-3.6 -> Run the unit test suite.
* unit-3.7 -> Run the unit test suite.
* unit-3.8 -> Run the unit test suite.
* system-3.7 -> Run the system test suite.
* cover -> Run the final coverage report.
* docs -> Build the docs for this library.
- docfx -> Build the docfx yaml files for this library.
sessions marked with * are selected, sessions marked with - are skipped. |
tseaver
added a commit
that referenced
this pull request
Jun 7, 2021
Post-owlbot refresh of PR #272.
crwilcox
pushed a commit
that referenced
this pull request
Jun 9, 2021
Post-owlbot refresh of PR #272.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.