This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Don't attempt to reconnect if the instance is no longer RUNNING. #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojarjur
previously approved these changes
May 17, 2017
tools/cli/commands/connect.py
Outdated
| # Before we try to reconnect, check to see if the VM is still running. | ||
| status, metadata_items = utils.describe_instance( | ||
| args, gcloud_compute, instance) | ||
| if status != 'RUNNING': |
There was a problem hiding this comment.
Now that we are using 'RUNNING' in two different places, perhaps we should define a constant for it.
tools/cli/commands/connect.py
Outdated
| @@ -277,6 +277,13 @@ def connect_and_check(): | |||
| return | |||
| if remaining_reconnects == 0: | |||
| return | |||
| # Before we try to reconnect, check to see if the VM is still running. | |||
| status, metadata_items = utils.describe_instance( | |||
There was a problem hiding this comment.
I would rename metadata_items to unused_metadata_items to make it clear that we don't need that part of the return value.
ojarjur
approved these changes
May 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1111. If the instance is no longer RUNNING when it is time to attempt to reconnect, it just prints a message and exits.