Skip to content

fix: go run multiple packages #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 21, 2025
Merged

fix: go run multiple packages #104

merged 3 commits into from
Apr 21, 2025

Conversation

rishavmehra
Copy link
Contributor

Issue: #103

@rishavmehra rishavmehra requested a review from a team as a code owner April 21, 2025 08:50
@CLAassistant
Copy link

CLAassistant commented Apr 21, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

csmarchbanks
csmarchbanks reviewed Apr 21, 2025
View reviewed changes
Copy link
Contributor

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A small suggestion, and it looks like the CLA needs to be signed.

rishavmehra and others added 2 commits April 21, 2025 20:01
@rishavmehra @csmarchbanks
Update Makefile
18c663f 
Co-authored-by: Chris Marchbanks <[email protected]>
@rishavmehra @csmarchbanks
Update Makefile
8d821fd 
Co-authored-by: Chris Marchbanks <[email protected]>
@rishavmehra
Copy link
Contributor Author

Thanks! I’ve updated the Makefile and signed the CLA

@csmarchbanks csmarchbanks merged commit ab07634 into grafana:main Apr 21, 2025
5 checks passed
@sd2k sd2k mentioned this pull request Apr 22, 2025
Closed
ioanarm pushed a commit that referenced this pull request Apr 22, 2025
@rishavmehra @csmarchbanks @ioanarm
fix: go run multiple packages (#104)
8360712 
* fix: go run multiple packages

Signed-off-by: rishavmehra <[email protected]>

* Update Makefile

Co-authored-by: Chris Marchbanks <[email protected]>

---------

Signed-off-by: rishavmehra <[email protected]>
Co-authored-by: Chris Marchbanks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csmarchbanks csmarchbanks csmarchbanks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rishavmehra @CLAassistant @csmarchbanks