-
Notifications
You must be signed in to change notification settings - Fork 101
feat: add base-path flag for sse server #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
726a5b1
to
cc4df80
Compare
Thanks for the PR! Our e2e tests are failing but I think that's for an unrelated reason. Otherwise this LGTM, so I'll try to get those fixed ASAP and merge. |
@marin-h if you rebase on top of |
cc4df80
to
824388e
Compare
@sd2k thanks for the heads up and the approval! Apparently some E2E tests are still failing. Let me know if I need to do anything else please |
Yeah really sorry, this is the first external PR we've had since adding more tests, I think we'll need to resolve #140 first then it'll need one more rebase 😬 I'll be able to do that first thing tomorrow morning. |
#141 was merged so this should be good to go after a rebase 👍 thanks for your patience! |
Head branch was pushed to by a user without write access
824388e
to
ecbf9ae
Compare
Nice, I've pushed the v0.4.1 tag so this should be good to go. |
Thank you! |
@sd2k This is probably a noob question, but do you know when this new release 0.4.1 will be available in the Docker registry? I couldn't find any information on the Docker release process. Thanks! |
@marin-h oddly enough I don't know much about the Docker release process either, I think it's done automatically by Docker. It looks like they built a new Edit: I just checked and it is indeed in there! |
Yeah I was guessing the same thing but it is not :/
|
Oh now it is! Hahah just about time XD |
Description: Optional flag for setting a base path prefix for the SSE server.
Explanation: I needed to add this to run the MCP SSE server along with other MCP servers as containers behind a single HTTP proxy.
If there's a better way to do this let me know, I have little experience with MCP :)
fixes issue #138