Skip to content

xds: filter EDS localities with clarified specifications #6874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2020
Merged

xds: filter EDS localities with clarified specifications #6874

merged 2 commits into from
Mar 30, 2020

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Mar 30, 2020

Changes in processing EDS responses:

@voidzcy
Fix logic of filtering localites in EDS responses. Each LocalityLbEnd…
5c4e15e 
…points message is allowed to contain 0 LbEndpoints. LocalityLbEndpoints without or with 0 weight are ignored. NACK responses with sparse locality priorities.
@voidzcy voidzcy requested a review from dapengzhang0 March 30, 2020 19:01
@voidzcy voidzcy added the TODO:backport PR needs to be backported. Removed after backport complete label Mar 30, 2020
@voidzcy voidzcy merged commit 68391e4 into grpc:master Mar 30, 2020
voidzcy added a commit to voidzcy/grpc-java that referenced this pull request Mar 30, 2020
@voidzcy
xds: filter EDS localities with clarified specifications (grpc#6874)
2dfda15 
Fix logic of filtering localites in EDS responses:
   - Each LocalityLbEndpoints message is allowed to contain 0 LbEndpoints. 
   - LocalityLbEndpoints without or with 0 weight are ignored. 
   - NACK responses with sparse locality priorities.
@voidzcy voidzcy mentioned this pull request Mar 30, 2020
Merged
voidzcy added a commit that referenced this pull request Mar 30, 2020
@voidzcy
xds: filter EDS localities with clarified specifications (#6874) (#6875)
2581a57 
Fix logic of filtering localites in EDS responses:
   - Each LocalityLbEndpoints message is allowed to contain 0 LbEndpoints. 
   - LocalityLbEndpoints without or with 0 weight are ignored. 
   - NACK responses with sparse locality priorities.
@voidzcy voidzcy mentioned this pull request Mar 31, 2020
Merged
@ejona86 ejona86 removed the TODO:backport PR needs to be backported. Removed after backport complete label May 26, 2020
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@voidzcy @dfawley
xds: filter EDS localities with clarified specifications (grpc#6874)
166917d 
Fix logic of filtering localites in EDS responses:
   - Each LocalityLbEndpoints message is allowed to contain 0 LbEndpoints. 
   - LocalityLbEndpoints without or with 0 weight are ignored. 
   - NACK responses with sparse locality priorities.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dapengzhang0 dapengzhang0 dapengzhang0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@voidzcy @dapengzhang0 @ejona86