Skip to content

xds: filter EDS localities with clarified specifications #6874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Mar 30, 2020

Changes in processing EDS responses:

…points message is allowed to contain 0 LbEndpoints. LocalityLbEndpoints without or with 0 weight are ignored. NACK responses with sparse locality priorities.
@voidzcy voidzcy requested a review from dapengzhang0 March 30, 2020 19:01
@voidzcy voidzcy added the TODO:backport PR needs to be backported. Removed after backport complete label Mar 30, 2020
@voidzcy voidzcy merged commit 68391e4 into grpc:master Mar 30, 2020
voidzcy added a commit to voidzcy/grpc-java that referenced this pull request Mar 30, 2020
Fix logic of filtering localites in EDS responses:
   - Each LocalityLbEndpoints message is allowed to contain 0 LbEndpoints. 
   - LocalityLbEndpoints without or with 0 weight are ignored. 
   - NACK responses with sparse locality priorities.
voidzcy added a commit that referenced this pull request Mar 30, 2020
Fix logic of filtering localites in EDS responses:
   - Each LocalityLbEndpoints message is allowed to contain 0 LbEndpoints. 
   - LocalityLbEndpoints without or with 0 weight are ignored. 
   - NACK responses with sparse locality priorities.
@ejona86 ejona86 removed the TODO:backport PR needs to be backported. Removed after backport complete label May 26, 2020
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
Fix logic of filtering localites in EDS responses:
   - Each LocalityLbEndpoints message is allowed to contain 0 LbEndpoints. 
   - LocalityLbEndpoints without or with 0 weight are ignored. 
   - NACK responses with sparse locality priorities.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants