Skip to content

Fix a bug that prevents copy values from comments #11103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

budnix
Copy link
Member

@budnix budnix commented Jul 19, 2024

Context

The PR fixes a bug that prevents copy values from cell comments. The fix prevents calling the preventDefault on the event object when the action is triggered on the internal HoT element (the element has a data-hot-input attribute).

How has this been tested?

I tested the changes locally, and I covered the fix with three new tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/1983

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Jul 19, 2024
@budnix budnix marked this pull request as ready for review July 19, 2024 12:10
@budnix budnix requested a review from jansiegel July 19, 2024 12:10
Copy link

codesandbox-ci bot commented Jul 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c652ba9:

Sandbox Source
handsontable-javascript-demo Configuration
handsontable-typescript-demo Configuration
handsontable-react-demo Configuration
handsontable-vue-2-demo Configuration
handsontable-vue-3-demo Configuration
handsontable-angular-demo Configuration

@krzysztofspilka krzysztofspilka changed the title Fix a bug that prevents copy valus from comments Fix a bug that prevents copy values from comments Jul 19, 2024
Copy link

github-actions bot commented Jul 23, 2024

Launch the local version of documentation by running:

npm run docs:review 95c0db7c64edb0653a2698ca80c78ca166cf8b59

@budnix budnix merged commit 5b6e8d3 into develop Jul 24, 2024
24 checks passed
@budnix budnix deleted the feature/dev-issue-1983 branch July 24, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants