Skip to content

Fix merge cells height calculation, and revert line-height style changes #11423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

adrianspdev
Copy link
Contributor

Context

This PR includes fixes for merge cells plugin row height calculation, problem with gap between the selected cell at the edge of the viewport and misaligned when editing a cell in the first row.

How has this been tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. https://github.com/handsontable/dev-handsontable/issues/2219
  2. https://github.com/handsontable/dev-handsontable/issues/2220
  3. https://github.com/handsontable/dev-handsontable/issues/2208

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/react-wrapper
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

  • Fix for problem with gap between the selected cell at the edge of the viewport
  • Fix for misaligned when editing a cell in the first row
  • Fix for merge cell row height calculation

@adrianspdev adrianspdev requested a review from jansiegel February 4, 2025 15:50
@adrianspdev adrianspdev self-assigned this Feb 4, 2025
Copy link

codesandbox-ci bot commented Feb 4, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fa4c81c:

Sandbox Source
handsontable-pr-javascript-demo Configuration
handsontable-ts-demo Configuration
handsontable-pr-react-demo Configuration

@adrianspdev adrianspdev merged commit 98701d6 into develop Feb 5, 2025
27 checks passed
@adrianspdev adrianspdev deleted the feature/dev-issue-2219 branch February 5, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants