Skip to content

Revert actionType class field for UndoRedo actions #11495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 11, 2025

Conversation

budnix
Copy link
Member

@budnix budnix commented Mar 11, 2025

Context

The PR reverts the actionType class field from the UndoRedo plugin actions/events. The field was mistakenly removed in 15.0. Moreover, the PR improves the typings for those actions by updating some of them and adding missing ones.

How has this been tested?

I covered the changes with new tests that cover all action types.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/2292

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Mar 11, 2025
@budnix budnix marked this pull request as ready for review March 11, 2025 09:15
@budnix budnix requested review from qunabu and jansiegel March 11, 2025 09:22
Copy link

codesandbox-ci bot commented Mar 11, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d9bbc5d:

Sandbox Source
handsontable-pr-javascript-demo Configuration
handsontable-ts-demo Configuration
handsontable-pr-react-demo Configuration

Copy link

Launch the local version of documentation by running:

npm run docs:review e8f2ed04d0f87ce0925e27bcef8ac708f5804c98

@budnix budnix merged commit 386be3b into develop Mar 11, 2025
30 checks passed
@budnix budnix deleted the feature/dev-issue-2292 branch March 11, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants