Skip to content

Fix custom borders overlap problem #11551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 20, 2025
Merged

Fix custom borders overlap problem #11551

merged 6 commits into from
May 20, 2025

Conversation

adrianspdev
Copy link
Contributor

@adrianspdev adrianspdev commented Mar 27, 2025

Context

This PR includes fixes for the issue with overlapping borders. After the changes, all borders should be placed inside the table.

Classic
Before:
classic-before
After:
classic-after

Main
Before:
main-before
After:
main-after

Horizon
Before:
horizon-before
After:
horizon-after

How has this been tested?

Locally and covered by new visual test case

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issue(s):

  1. https://github.com/handsontable/dev-handsontable/issues/638

Affected project(s):

  • handsontable

Checklist:

@adrianspdev adrianspdev self-assigned this Mar 27, 2025
Copy link

codesandbox-ci bot commented Mar 27, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 624d8e7:

Sandbox Source
handsontable-pr-javascript-demo Configuration
handsontable-ts-demo Configuration
handsontable-pr-react-demo Configuration

budnix
budnix previously approved these changes Mar 27, 2025
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better 👍

qunabu
qunabu previously approved these changes Mar 27, 2025
@adrianspdev adrianspdev dismissed stale reviews from qunabu and budnix via 194dd90 March 27, 2025 08:41
@budnix budnix self-requested a review March 27, 2025 08:45
budnix
budnix previously approved these changes Mar 27, 2025
@budnix budnix self-requested a review March 27, 2025 10:09
budnix
budnix previously approved these changes Mar 27, 2025
@adrianspdev adrianspdev merged commit 4bbbdaf into develop May 20, 2025
35 of 36 checks passed
@adrianspdev adrianspdev deleted the feature/dev-issue-638 branch May 20, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants