Skip to content

Fix disableVisualSelection problem after call updateData #11558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

adrianspdev
Copy link
Contributor

Context

"This PR includes a fix for the issue with highlighting the cell when disableVisualSelection is set to false and the updateData method is called. This issue occurs in the React wrapper after a re-render.

How has this been tested?

Locally and covered with e2e test case

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. https://github.com/handsontable/dev-handsontable/issues/2324

Affected project(s):

  • handsontable
  • @handsontable/react

Checklist:

@adrianspdev adrianspdev self-assigned this Mar 31, 2025
Copy link

codesandbox-ci bot commented Mar 31, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e1bc503:

Sandbox Source
handsontable-pr-javascript-demo Configuration
handsontable-ts-demo Configuration
handsontable-pr-react-demo Configuration

budnix
budnix previously approved these changes Mar 31, 2025
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a comment with a small suggestion for improvement for your consideration :)

Co-authored-by: Krzysztof ‘Budzio’ Budnik <[email protected]>
@adrianspdev adrianspdev merged commit f3e29be into develop Apr 1, 2025
31 checks passed
@adrianspdev adrianspdev deleted the feature/dev-issue-2324 branch April 1, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants