pool: make relevant items pub
#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Dec 16, 2022
| @@ -33,7 +33,7 @@ pub(super) struct Pool<T> { | |||
| // This is a trait to allow the `client::pool::tests` to work for `i32`. | |||
| // | |||
| // See https://github.com/hyperium/hyper/issues/1429 | |||
| pub(super) trait Poolable: Unpin + Send + Sized + 'static { | |||
| pub trait Poolable: Unpin + Send + Sized + 'static { | |||
There was a problem hiding this comment.
I'm fine with just making it all public to start with, to unblock people, but I do think the exposed design could be improved, by making the Pool basically a MakeService over another MakeService (a caching layer over the Connect stuff).
Currently `pool` is not pub, and nothing `pub` uses it, so it isn't accessible. This exposes them for use.
seanmonstar
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
poolis not pub, and nothingpubuses it, so it isn't accessible. This exposes them for use.Discussed here: https://discordapp.com/channels/500028886025895936/670880858630258689/1053021031805227109