Skip to content

Commit d312472

Browse files
Testing updated transitive dep of react-remove-scroll (radix-ui#2776)
1 parent b64b9f1 commit d312472

File tree

3 files changed

+44
-37
lines changed

3 files changed

+44
-37
lines changed

.yarn/versions/eb020608.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
declined:
2+
- primitives

packages/react/select/src/Select.stories.tsx

Lines changed: 39 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -638,40 +638,45 @@ export const RequiredWithinForm = () => {
638638
};
639639

640640
export const WithinDialog = () => (
641-
<Dialog.Root>
642-
<Dialog.Trigger>Open Dialog</Dialog.Trigger>
643-
<Dialog.Content aria-describedby={undefined}>
644-
<Dialog.Title>A select in a dialog</Dialog.Title>
645-
<Label>
646-
Choose a number:
647-
<Select.Root defaultValue="2">
648-
<Select.Trigger className={triggerClass()}>
649-
<Select.Value />
650-
<Select.Icon />
651-
</Select.Trigger>
652-
<Select.Portal>
653-
<Select.Content className={contentClass()}>
654-
<Select.ScrollUpButton className={scrollUpButtonClass()}></Select.ScrollUpButton>
655-
<Select.Viewport className={viewportClass()}>
656-
{Array.from({ length: 30 }, (_, i) => (
657-
<Select.Item key={i} className={itemClass()} value={String(i)}>
658-
<Select.ItemText>Item {i}</Select.ItemText>
659-
<Select.ItemIndicator className={indicatorClass()}>
660-
<TickIcon />
661-
</Select.ItemIndicator>
662-
</Select.Item>
663-
))}
664-
</Select.Viewport>
665-
<Select.ScrollDownButton className={scrollDownButtonClass()}>
666-
667-
</Select.ScrollDownButton>
668-
</Select.Content>
669-
</Select.Portal>
670-
</Select.Root>
671-
</Label>
672-
<Dialog.Close>Close Dialog</Dialog.Close>
673-
</Dialog.Content>
674-
</Dialog.Root>
641+
<div style={{ height: '120vh' }}>
642+
<Dialog.Root>
643+
<Dialog.Trigger>Open Dialog</Dialog.Trigger>
644+
<Dialog.Portal>
645+
<Dialog.Overlay />
646+
<Dialog.Content aria-describedby={undefined} style={{ position: 'fixed', top: 100 }}>
647+
<Dialog.Title>A select in a dialog</Dialog.Title>
648+
<Label>
649+
Choose a number:
650+
<Select.Root defaultValue="2">
651+
<Select.Trigger className={triggerClass()}>
652+
<Select.Value />
653+
<Select.Icon />
654+
</Select.Trigger>
655+
<Select.Portal>
656+
<Select.Content className={contentClass()}>
657+
<Select.ScrollUpButton className={scrollUpButtonClass()}></Select.ScrollUpButton>
658+
<Select.Viewport className={viewportClass()}>
659+
{Array.from({ length: 30 }, (_, i) => (
660+
<Select.Item key={i} className={itemClass()} value={String(i)}>
661+
<Select.ItemText>Item {i}</Select.ItemText>
662+
<Select.ItemIndicator className={indicatorClass()}>
663+
<TickIcon />
664+
</Select.ItemIndicator>
665+
</Select.Item>
666+
))}
667+
</Select.Viewport>
668+
<Select.ScrollDownButton className={scrollDownButtonClass()}>
669+
670+
</Select.ScrollDownButton>
671+
</Select.Content>
672+
</Select.Portal>
673+
</Select.Root>
674+
</Label>
675+
<Dialog.Close>Close Dialog</Dialog.Close>
676+
</Dialog.Content>
677+
</Dialog.Portal>
678+
</Dialog.Root>
679+
</div>
675680
);
676681

677682
export const ChromaticShortOptionsPaddedContent = () => (

yarn.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17076,8 +17076,8 @@ __metadata:
1707617076
linkType: hard
1707717077

1707817078
"react-remove-scroll-bar@npm:^2.3.3, react-remove-scroll-bar@npm:^2.3.4":
17079-
version: 2.3.5
17080-
resolution: "react-remove-scroll-bar@npm:2.3.5"
17079+
version: 2.3.6
17080+
resolution: "react-remove-scroll-bar@npm:2.3.6"
1708117081
dependencies:
1708217082
react-style-singleton: "npm:^2.2.1"
1708317083
tslib: "npm:^2.0.0"
@@ -17087,7 +17087,7 @@ __metadata:
1708717087
peerDependenciesMeta:
1708817088
"@types/react":
1708917089
optional: true
17090-
checksum: 10/6d05e74ee8049b322ba0aeb398e092ae284a5b04013bc07f0c1f283824b088fd5c1b1f1514a0e0e501c063a9c3b5899373039329d0266a21121222c814052053
17090+
checksum: 10/5ab8eda61d5b10825447d11e9c824486c929351a471457c22452caa19b6898e18c3af6a46c3fa68010c713baed1eb9956106d068b4a1058bdcf97a1a9bbed734
1709117091
languageName: node
1709217092
linkType: hard
1709317093

0 commit comments

Comments
 (0)