Skip to content

Fix indentation and row label wrapping #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 26, 2023

Conversation

Melkiades
Copy link
Contributor

Fix #85 #84

@Melkiades Melkiades added sme Tracks changes for the sme board bug Something isn't working labels Jan 16, 2023
@Melkiades Melkiades linked an issue Jan 20, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------
R/format_value.R       195      15  92.31%   72, 156, 175, 246, 359-366, 375, 386, 394
R/generics.R            82      20  75.61%   154-160, 173, 183, 236-241, 290-301, 374, 386, 419, 448, 460
R/labels.R              55       7  87.27%   53, 59, 68, 109, 137, 146, 150
R/matrix_form.R        174      34  80.46%   48-51, 178-193, 279, 301-306, 346-351, 373-383, 420
R/mpf_exporters.R      133     133  0.00%    3-221
R/page_size.R           43       8  81.40%   31-34, 64-70
R/pagination.R         184      44  76.09%   185, 199-208, 211-214, 221-240, 248-257, 287, 343-344, 346, 391
R/tostring.R           339      55  83.78%   7-12, 12-13, 13-14, 14-15, 15-16, 16-17, 17-18, 18-20, 20-22, 152-155, 294-295, 379, 394, 501-515, 555, 591, 628-631, 635, 643, 684, 691
R/utils.R                1       0  100.00%
TOTAL                 1206     316  73.80%

Diff against main

Filename        Stmts    Miss  Cover
------------  -------  ------  -------
R/tostring.R       +8       0  +0.39%
TOTAL              +8       0  +0.17%

Results for commit: ee35bfa

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

inset <- table_inset(mat)

if(tf_wrap) browser()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need this removed before we can merge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I removed in commit forgot browser

but I do not understand the errors that are still blocking this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem comes from the following... How did you solve the problem @gmbecker?

So to conclude, this isn't me not liking that we're doing linting, or even the settings of the linter. This is the linter fundamentally not functioning properly within the GH action.

Originally posted by @gmbecker in #83 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sme Tracks changes for the sme board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when more than one rowname is to be wrapped with indentation Row label wrapping with identical indentation
2 participants