Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ionic-team/ionic-framework
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.5.6
Choose a base ref
...
head repository: ionic-team/ionic-framework
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.5.7
Choose a head ref
  • 4 commits
  • 36 files changed
  • 4 contributors

Commits on Apr 30, 2025

  1. Configuration menu
    Copy the full SHA
    e6e6483 View commit details
    Browse the repository at this point in the history
  2. merge release-8.5.6 (#30381)

    v8.5.6
    brandyscarney authored Apr 30, 2025
    Configuration menu
    Copy the full SHA
    bf396c9 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2025

  1. fix(labels): prevent clicking a label from triggering onClick twice o…

    …n several components (#30384)
    
    Issue number: resolves #30165
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    Currently, several components will trigger their `onClick` twice if you
    click on their labels.
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    After this fix, the affected components will only trigger `onClick` once
    per click of their labels or click directly on the element.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [X] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    
    The affected components are:
    - Checkbox
    - Select
    - Textarea
    - Toggle
    - Input
    
    I also tested radio and range but could not reproduce the issue for
    them.
    
    Note that two of the components, checkbox and toggle, had to have
    special implementations for both their test and fix because of how the
    host component acts as the component for accessibility purposes.
    
    Current dev build: `8.5.7-dev.11746044124.147aab6c`
    
    ---------
    
    Co-authored-by: Maria Hutt <[email protected]>
    Co-authored-by: Brandy Smith <[email protected]>
    3 people authored May 2, 2025
    Configuration menu
    Copy the full SHA
    7d639b0 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2025

  1. v8.5.7

    Ionitron committed May 7, 2025
    Configuration menu
    Copy the full SHA
    af6b865 View commit details
    Browse the repository at this point in the history
Loading