feat: Secure live updates #31
Conversation
and configuration based Portals. feat(web): Make all exported functions awaitable.
chore(android): Reorganize code
| null -> map.putNull(key) | ||
| else -> map.putString(key, value.toString()) | ||
| } | ||
| } catch (_: JSONException) { |
| null -> array.pushNull() | ||
| else -> array.pushString(value.toString()) | ||
| } | ||
| } catch (_: JSONException) { |
There was a problem hiding this comment.
The exception never should occur since we're accessing by index from 0 ..< length, but I also don't want to potentially throw an uncatchable exception and crash the application. Technically in Kotlin I could write this without being in the try/catch block since Kotlin doesn't have checked exceptions.
There was a problem hiding this comment.
Also, this method is for marshaling data to and from Portals to RN
| @@ -3,7 +3,7 @@ | |||
| // ReactNativePortals | |||
| // | |||
| // Created by Steven Sherry on 4/1/22. | |||
| // Copyright © 2022 Facebook. All rights reserved. | |||
| // Copyright © 2022 Ionic. All rights reserved. | |||
| val configJson = try { | ||
| JSONObject(config) | ||
| } catch (e: JSONException) { | ||
| throw Error("Portals config data is malformed. Aborting.", e) |
There was a problem hiding this comment.
@giralte-ionic we throw here if the config is not serializable
| usesSecureLiveUpdates = true | ||
| } | ||
|
|
||
| val portalJsonArray = configJson.getJSONArray("portals") |
There was a problem hiding this comment.
@giralte-ionic this throws here if the portals key is not available
| val portalJsonArray = configJson.getJSONArray("portals") | ||
|
|
||
| for (index in 0 until portalJsonArray.length()) { | ||
| val portalJson = portalJsonArray.getJSONObject(index) |
There was a problem hiding this comment.
@giralte-ionic this throws here if the index is not accessible
Adds secure live updates for React Native. Also overhauled a bit of the code organization.
BREAKING: Makes previously non-async methods async. The module methods that were not async were essentially doing fire and forget making it impossible to synchronize on the user end. This was not much of an issue until adding secure live updates where the order in which those effects were executed were not in any guaranteed order. This technically isn't a source breaking change, but it is behavior changing.