client: {useIframe: false} not taken from config file

If I want this option, I need to add it to grunt config itself.

[dignifiedquire]

Can you please describe in more detail what you are trying to achieve and what you tried and did not work for you?

I just want to use option useIframe: false. Ad "what you are trying to achieve", I hope you are not saying I should explain why I want to use that option - I have my reasons.

When it is specified in .conf file, it works fine from cli karma, but it is not honoured when used in grunt-karma. Hence, bug. As a workaround, I need to put options: {useIframe: false} into Gruntfile itself. Please, will you accept this bug (useIframe setting in .conf is not taken by grunt-karma)?

It is a bug, isn't it?

[dignifiedquire]

So you are saying you are setting the value in the your karma.conf.js file, and when running it via the cli it works fine, but when running it through grunt-karma it is not honoured? Could you share how your grunt-karma config looks like then please?

It is pointing to that config file, but useIframe is not honoured. Other settings are.

Friedel Ziegelmayer wrote:

So you are saying you are setting the value in the your
|karma.conf.js| file, and when running it via the cli it works fine,
but when running it through grunt-karma it is not honoured? Could you
share how your grunt-karma config looks like then please?

—
Reply to this email directly or view it on GitHub
#165 (comment).

The problem seems to be here:

grunt-karma/tasks/grunt-karma.js

Lines 40 to 56 in 70cdb94

	// If arguments are provided we pass them to karma
	if (args.length > 0) {
	if (!options.client) {
	options.client = {}
	}
	options.client.args = args
	}
	// Only create client info if data is provided
	if (options.client) {
	// Merge karma default options
	_.defaults(options.client, {
	args: [],
	useIframe: true,
	captureConsole: true
	})
	}

.
Since I do not run grunt, but grunt taskname, the client is set to {}, then gets the defaults applied, setting useIframe always to true, and all this before taking configfile into account.

No, in fact, this is the root cause:

grunt-karma/tasks/grunt-karma.js

Line 31 in 70cdb94

client: {}

.

Or maybe this 168f7b7. Why was useIframe: true set as default explicitly; is it needed?

Re: "PR please" @dignifiedquire I am not really sure how to solve this, as there is many places and they depend on each other, so you could probably know better (or some other core devs).

[gnail]

Can confirm that the default settings overrides the config file and sets UseIframe to true regardless of the config file. I ran into this while trying to get karma-electron to work which requires UseIframe to be false in order to expose the Node.js API visible from the renderer. Removing line 53 solves my problem.