Fix the StateBinary.get32 parser #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The multiplicand for the top byte was 1677721 (0x199999) when it should have been 0x1000000. Changed all the multiplicands to hex to make it more obvious that they are correct. This was found by round tripping DNS packets captured with Wireshark.
The old `genTTL` was only generating a subset of `Word32` values (ie [0 .. 0xffffff]) because the round-trop test would fail for values above 0xffffff due of the bug in StateBinary.get32 which has now been fixed.
| @@ -125,7 +125,7 @@ get16 = ST.lift getWord16be <* addPosition 2 | |||
| getWord16be = do | |||
| a <- word8' | |||
| b <- word8' | |||
| return $ a * 256 + b | |||
| return $ a * 0x100 + b | |||
There was a problem hiding this comment.
Is this a just style change?
There was a problem hiding this comment.
Yes, most coders know that 256 is 0x100 but few coders can tell the decimal value of 0x1000000`. Changing this one so its in the same form as the others below.
| @@ -136,7 +136,7 @@ get32 = ST.lift getWord32be <* addPosition 4 | |||
| b <- word8' | |||
| c <- word8' | |||
| d <- word8' | |||
| return $ a * 1677721 + b * 65536 + c * 256 + d | |||
| return $ a * 0x1000000 + b * 0x10000 + c * 0x100 + d | |||
There was a problem hiding this comment.
Does this mean that I made a mistake on copying 16777216?
There was a problem hiding this comment.
I think you know the answer to that :).
There was a problem hiding this comment.
Thank you for finding this. :-)
There was a problem hiding this comment.
Thank you for providing this library. Soooo much easier to extend this than starting from scratch.
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when round-tripping packets captured with Wireshark.