Skip to content

Fix guide links in README #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

ChristopherFry
Copy link
Contributor

This pull request corrects the guide links in the README. Currently the links refer to a guides subfolder although the guides exist within the same folder as the README. This pull request also removes a duplicate link from the README.

@ChristopherFry
Copy link
Contributor Author

This may a non-issue and working as intended. Links appear to be okay on kpt.dev, just not when you view the README directly in GitHub, https://github.com/GoogleContainerTools/kpt/blob/main/site/guides/README.md.

Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix @ChristopherFry I think my last PR caused this issue.

@droot droot merged commit 44beccf into kptdev:main May 10, 2022
@droot droot mentioned this pull request May 10, 2022
ChristopherFry added a commit to ChristopherFry/kpt that referenced this pull request May 10, 2022
droot pushed a commit that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants