Skip to content

Add Slack channels for Indonesian and Portuguese #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2019
Merged

Add Slack channels for Indonesian and Portuguese #3605

merged 1 commit into from
Apr 16, 2019

Conversation

zacharysarah
Copy link
Contributor

@zacharysarah zacharysarah commented Apr 16, 2019 •
edited
Loading

Fixes #3603

This PR adds two new Slack channels for Indonesian and Portuguese docs.

/assign @Katharine
/ref #3604 (comment)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/community-management area/slack-management Issues or PRs related to the Slack Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2019
@Katharine
Copy link
Member

Thanks for dealing with our churn while we figure out our new system! As compensation, in the future, you can create these channels without slack-admin involvement by getting an LGTM from within your sig.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
alejandrox1
alejandrox1 approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@alejandrox1 alejandrox1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alejandrox1, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a42db77 into kubernetes:master Apr 16, 2019
@zacharysarah zacharysarah deleted the two-new-slack-channels branch April 16, 2019 20:47
@mrbobbytables
Copy link
Member

/pony yay

@k8s-ci-robot
Copy link
Contributor

@mrbobbytables: pony image

In response to this:

/pony yay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rlenferink rlenferink mentioned this pull request Apr 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrox1 alejandrox1 alejandrox1 approved these changes

@castrojo castrojo Awaiting requested review from castrojo

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@Katharine Katharine

@alejandrox1 alejandrox1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management area/slack-management Issues or PRs related to the Slack Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REQUEST: New Slack channels kubernetes-docs-id kubernetes-docs-pt
5 participants
@zacharysarah @Katharine @k8s-ci-robot @mrbobbytables @alejandrox1