Skip to content

KEP-596: Update graduation criteria and test results #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Jul 28, 2022

  • One-line PR description:
    KEP-596: Update graduation criteria and test results
  • Other comments:

This PR follows up on the remaining action items in the graduation criteria.

/cc @jsafrane @msau42 @xing-yang @wojtek-t

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jul 28, 2022
- [ ] Upgrade / downgrade manual testing, document results in the [upgrade / rollback section](#rollout-upgrade-and-rollback-planning).
- [ ] Provide measurements for the [Scalability section](#scalability) (time taken to start a pod)
- [ ] Ensure our sponsored [NFS](https://github.com/kubernetes-csi/csi-driver-nfs) and [SMB](https://github.com/kubernetes-csi/csi-driver-smb) CSI drivers align with the new guidance in [Security Considerations](#security-considerations)
- [ ] Conformance tests implemented / promoted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think even though full end to end functionality may not be easily supported in conformance, we can still test API operations, similar to https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/csistoragecapacity.go

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added as a separate commit in kubernetes/kubernetes#111258

@dobsonj dobsonj force-pushed the kep-596-grad-crit branch from 11ca24b to c896ea5 Compare August 4, 2022 23:10
@msau42
Copy link
Member

msau42 commented Aug 5, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 217d790 into kubernetes:master Aug 5, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 5, 2022
a pod mounting 5 secrets and a pod mounting 5 CSI inline volumes using the
[CSI Hostpath Driver](https://github.com/kubernetes-csi/csi-driver-host-path).
In both cases, the pod takes 3-4 seconds to transition from "PodScheduled" to
"Ready" on a single node cluster. Results may vary depending on the CSI driver.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PRR!
It LGTMT (sorry for delay).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants