-
Notifications
You must be signed in to change notification settings - Fork 1.5k
KEP-596: Update graduation criteria and test results #3445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- [ ] Upgrade / downgrade manual testing, document results in the [upgrade / rollback section](#rollout-upgrade-and-rollback-planning). | ||
- [ ] Provide measurements for the [Scalability section](#scalability) (time taken to start a pod) | ||
- [ ] Ensure our sponsored [NFS](https://github.com/kubernetes-csi/csi-driver-nfs) and [SMB](https://github.com/kubernetes-csi/csi-driver-smb) CSI drivers align with the new guidance in [Security Considerations](#security-considerations) | ||
- [ ] Conformance tests implemented / promoted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think even though full end to end functionality may not be easily supported in conformance, we can still test API operations, similar to https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/csistoragecapacity.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added as a separate commit in kubernetes/kubernetes#111258
11ca24b
to
c896ea5
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dobsonj, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a pod mounting 5 secrets and a pod mounting 5 CSI inline volumes using the | ||
[CSI Hostpath Driver](https://github.com/kubernetes-csi/csi-driver-host-path). | ||
In both cases, the pod takes 3-4 seconds to transition from "PodScheduled" to | ||
"Ready" on a single node cluster. Results may vary depending on the CSI driver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PRR!
It LGTMT (sorry for delay).
KEP-596: Update graduation criteria and test results
CSI Inline Volume Support #596
This PR follows up on the remaining action items in the graduation criteria.
/cc @jsafrane @msau42 @xing-yang @wojtek-t