-
Notifications
You must be signed in to change notification settings - Fork 22.9k
FF145 Storage Access HTTP headers #41614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FF145 Storage Access HTTP headers #41614
Conversation
|
Preview URLs
Flaws (6)Note! 2 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
External URLs (2)URL:
URL:
(comment last updated: 2025-11-07 09:28:59) |
|
@hamishwillee removing myself for now. When this is finished, feel free to add me back to review; happy to do so. |
|
Ditto! Add me back on as a reviewer when you're ready for a look 👀 |
8b0c4d6 to
17f04c2
Compare
files/en-us/web/http/reference/headers/sec-fetch-storage-access/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/http/reference/headers/activate-storage-access/index.md
Outdated
Show resolved
Hide resolved
|
@chrisdavidmills @bsmth I've added you back as reviewers as this is a reasonable first shot. Apologies that it is a bit rough - I have not yet self-subedited. Given I'm away after Friday this is the only way I can be sure it has a chance of being ready for the release. If it is simply not close to good enough we can wait though, as I did the release not separately. |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hamishwillee this is a truly heroic bit of work. I've got a whole bunch of nitpicky language comments, but it largely makes sense.
files/en-us/web/http/reference/headers/activate-storage-access/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/http/reference/headers/sec-fetch-storage-access/index.md
Outdated
Show resolved
Hide resolved
…s/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s/mermaid_iframe.svg
Co-authored-by: Chris Mills <[email protected]>
Co-authored-by: Chris Mills <[email protected]>
39a12f3 to
45aeaf2
Compare
THanks @chrisdavidmills - and thanks for your timely and heroic review. I did find it hard - the previous terminology didn't lend itself to integrating this update. Should be good to look at again. I have accepted pretty much all your suggestions. Only not reduced the description of the ActivateX... header - as noted, I don't think I can and leave it useful. |
|
PS Feel free to merge if remaining fixes end up being nits :-). I'm away so if it is essentially good enough then better to get it in. |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hamishwillee hurrah, I think this is ready to go in! Great work, man.
FF145 supports the HTTP headers
Activate-Storage-AccessandSec-Fetch-Storage-Accessin nightly, and they are already supported in Chrome 133.This adds docs. Bit of a slog. Mostly untangling the language we use around accessing the permission in the normal API docs.
The
Sec-Fetch-Storage-Accesslanguage makes this easier by clearly separating the permission that is granted to a particular embedded/embedder site key, and activating that permission for a particular context.I've tried to rewrite the how it works and add sequences that shows how this works. For the headers,
Activate-Storage-Accesshas lots of docs and is linked from
Sec-Fetch-Storage-Access.I have not updated "Using" doc. I probably should, but might do that when this is actually released.
Spec is https://privacycg.github.io/storage-access-headers , explainer is https://github.com/privacycg/storage-access-headers/blob/d73c092919f0ca44c02c0890c078046ef8a63a88/README.md
Related docs work can be tracked in #41499