Skip to content

[1.6 servicing] PackageDeploymentManager - Fix .Stop() events not being generated. Include PackageReadyOrNewerAvailableStatus in .Stop() events #5297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2025

Conversation

DrusTheAxe
Copy link
Member

@DrusTheAxe DrusTheAxe commented Mar 31, 2025

!cherry-pick 0562da1
!cherry-pick 3c17287

  • PackageDeploymentManager - Fix .Stop() events not being generated. Include PackageReadyOrNewerAvailableStatus in .Stop() events. #5278
  • PackageDeploymentManager - Add missing .Stop() event on CompletedSuccess #5284

https://task.ms/56951078

@DrusTheAxe DrusTheAxe added the area-Deployment Issues related to packaging, installation, runtime (e.g., SelfContained, Unpackaged) label Mar 31, 2025
@DrusTheAxe DrusTheAxe added this to the 1.6 milestone Mar 31, 2025
@DrusTheAxe DrusTheAxe self-assigned this Mar 31, 2025
@DrusTheAxe DrusTheAxe changed the base branch from main to release/1.6-stable March 31, 2025 17:33
@DrusTheAxe
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codendone
Copy link
Collaborator

    logTelemetry.Stop(packageUriAsString);

Are you intentionally not fixing these, like you did for 1.7?


Refers to: dev/PackageManager/API/M.W.M.D.PackageDeploymentManager.cpp:577 in a93477b. [](commit_id = a93477b, deletion_comment = False)

@DrusTheAxe
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe
Copy link
Member Author

    logTelemetry.Stop(packageUriAsString);

Are you intentionally not fixing these, like you did for 1.7?

Refers to: dev/PackageManager/API/M.W.M.D.PackageDeploymentManager.cpp:577 in a93477b. [](commit_id = a93477b, deletion_comment = False)

Grrr. Bad merge. The 1.7 PR has a couple of commits fixing this, same needed in 1.6. Fixing now. Thanks

@DrusTheAxe
Copy link
Member Author

DrusTheAxe commented Apr 3, 2025

    logTelemetry.Stop(packageUriAsString);

Are you intentionally not fixing these, like you did for 1.7?
Refers to: dev/PackageManager/API/M.W.M.D.PackageDeploymentManager.cpp:577 in a93477b. [](commit_id = a93477b, deletion_comment = False)

Grrr. Bad merge. The 1.7 PR has a couple of commits fixing this, same needed in 1.6. Fixing now. Thanks

P.S. With the latest commit PackageTelemetry.h is identical here (1.6) with 1.7 and M.W.M.D.PackageDeploymentManager.cpp is identical except 1.7 adds #include "PackageManager.Containment.h" and Containment check in the 1 if

 if (WinAppSdk::Containment::IsChangeEnabled<WINAPPSDK_CHANGEID_56439870>() && options.RegisterNewerIfAvailable())

making 1.6 not identical to 1.7 except 1.7 adds the containment check. As intended

@DrusTheAxe
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe DrusTheAxe merged commit 52fd056 into release/1.6-stable Apr 4, 2025
27 checks passed
@DrusTheAxe DrusTheAxe deleted the user/drustheaxe/pdm-telemetry-1.6 branch April 4, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Deployment Issues related to packaging, installation, runtime (e.g., SelfContained, Unpackaged) needs-triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants