Generated client throws exceptions when the body is an enumerable

[SiVGiV]

When attempting to send a request that has an enum as body through a generated client, an exception is thrown from SetContentFromScalar in RequestInfo (Microsoft.Kiota.Abstractions - 1.17.2).

The function contains a big switch function that is missing an option that allows an enum through.

Important to note that the enum was also generated by Kiota.

Function used to generate:

kiota generate --exclude-backward-compatible --class-name KiotaClient --output "./KiotaClient" --language CSharp --openapi "./KiotaClient.OpenAPI.yaml" --namespace-name "KiotaClient" --disable-ssl-validation --clean-output --clear-cache

OpenAPI schema example:

openapi: 3.0.3
info:
  version: v1.0
  title: KiotaClient Bug Example
  description: 
    Example
servers:
  - url: https://localhost:5000/
paths:
  "/api/":
    put:
      requestBody:
        required: true
        content:
          application/json; charset=utf-8:
            schema:
              $ref: "#/components/schemas/state"
            examples:
              started:
                summary: OptionA
                value: "OptionA"
              stopped:
                summary: OptionB
                value: "OptionB"
      responses:
        "204":
          description: State was changed

components:
  schemas:
    state:
      description: Device state
      type: string
      enum:
        - OptionA
        - OptionB

Edit:

Upon further investigation, this problem may be linked to the client generation and not Microsoft.Kiota.Abstractions, as a similar problem presents when the body of the request is of an UntypedNode type instead of an Enum.

There seems to be a problem with fitting the client request function body with the function body's type - no matter what type is sent, they're all sent to the SetContentAsScalar function, which lacks support for those types (Enum and UntypedNode are the ones I came across).

[baywet]

Hi @SiVGiV
Thank you for using kiota and for reaching out.

To clarify any potential confusion, did you mean "when the body is an enumeration"?

Can you please paste the generated code for the ToPutRequestInformation method please?

[SiVGiV]

Hey!

I meant when the body is an enum - but later found out that it's also a bug when the body is any UntypedNode.

Here's the code generated by with the code I provided:

        public RequestInformation ToPutRequestInformation(global::KiotaClient.Models.State? body, Action<RequestConfiguration<DefaultQueryParameters>>? requestConfiguration = default)
        {
#nullable restore
#else
        public RequestInformation ToPutRequestInformation(global::KiotaClient.Models.State? body, Action<RequestConfiguration<DefaultQueryParameters>> requestConfiguration = default)
        {
#endif
            _ = body ?? throw new ArgumentNullException(nameof(body));
            var requestInfo = new RequestInformation(Method.PUT, UrlTemplate, PathParameters);
            requestInfo.Configure(requestConfiguration);
            requestInfo.SetContentFromScalar(RequestAdapter, "application/json;charset=utf-8", body);
            return requestInfo;
        }

[baywet]

Thank you for the additional information.

This is most likely caused by the fact there is no case for handling enums here.

kiota-dotnet/src/abstractions/RequestInformation.cs

Line 490 in 4fac1d3

throw new InvalidOperationException($"error serialization data value with unknown type {item?.GetType()}");

I think that adding a new case for enums here is going to require adding some reflection, which will cause a set of issues down the road (trimming, AOT, etc...)

We could add an overload SetContentFromEnum which in turn calls this method.

kiota-dotnet/src/abstractions/RequestInformation.cs

Line 214 in 4fac1d3

private static string? GetEnumName<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicFields)] T>(T value) where T : Enum

Thoughts?

Is this something you'd like to submit a pull request for provided some guidance?