Skip to content

Remove existing attribute from autocomplete suggestions #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sapphi-red
Copy link
Contributor

This PR closes #80.

Copy link
Collaborator

@aeschli aeschli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case with an element that has multiple existing attributes and test completions also before the extension attributes

@aeschli
Copy link
Collaborator

aeschli commented Jan 4, 2021

Thanks @sapphi-red for the work. I added some comments...

@aeschli aeschli added this to the December/January 2021 milestone Jan 4, 2021
@sapphi-red
Copy link
Contributor Author

Thank you for reviewing, I have fixed it!

@aeschli aeschli modified the milestones: January 2021, February 2021 Feb 5, 2021
@aeschli
Copy link
Collaborator

aeschli commented Feb 5, 2021

Thanks a lot @sapphi-red !

@aeschli aeschli merged commit 106b074 into microsoft:master Feb 5, 2021
@sapphi-red sapphi-red deleted the remove-existing-arributes-from-suggestions branch February 6, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove existing element attributes from the autocomplete list
2 participants