Webviews can prevent keyboard shortcuts from working in quick picks

[tspence]

• VS Code Version: 1.50
• OS Version: Windows 10 && Mac OSX Catalina

Steps to Reproduce:

1. Open a full-editor webview in the main editor area
2. Open a text file in the editor
3. Close the text file using a keyboard shortcut (Cmd+W or Ctrl+F4); the full-editor webview should now receive focus
4. Press Cmd+P to open the quick-pick file selector
5. Select a file from the quick pick editor; VS Code will jump you to that file
6. While editing this file, press Cmd+P again to open the quick-pick file selector

Expected Results:

• I can use keyboard shortcuts for Cut / Copy / Paste while in the quick pick editor

Actual Results:

• All keyboard shortcuts are disabled in this quick pick window.

Root Cause:
During step 5 of the reproduction, VS Code switches focus to the code file you selected from the quick pick. Additionally, a delayed action fires as the quick pick closes. The delayed action tells the system to return focus to the element that previously had focus, which was the full-editor webview.

The full-editor webview thinks it has focus, and as a result it absorbs all cut/copy/paste commands that are defined in webview.contribution.ts.

Does this issue occur when all extensions are disabled?: No

[mjbvz]

Looks like you are on an old VS Code version. Does this reproduce in the latest VS Code insiders build?

[tspence]

@mjbvz I've been working on this in the Facebook build of VS Code, and we're usually a release or two behind. Prior to submitting this, we tried checking the latest branches to see if there were any changes in the pipeline that would fix it for us.

I tried pulling in this change into my current branch, which seemed very promising:
aa73c2d#diff-d290cb6d05c11d900910c208855317e2ba58816f563a4c2a6fd781564381e68e

Unfortunately, this change by itself didn't fix the problem, but it was that change that helped me identify that the root cause was the difference between document.activeElement and webview.isFocused. @evangrayk and I spent some time reviewing possible fixes before we decided to submit it upstream to you.

Let me know if you'd like me to record a walkthrough on a different build :)

[mjbvz]

Yes as a starting point, please test using the insiders VS Code release to see if this happens there as well. Then you will know if there are commits or not that would fix this issue for your custom VS Code build