Regression: Shell-Integration for fish-shell broken

[max06]

Does this issue occur when all extensions are disabled?: (not testable)

• VS Code Version: Insider 2c73d26
• OS Version: Win11 (Gui) / Ubuntu 22.04 (ssh) / Debian11 (Container)

The shell integration for the fish-shell is broken due to wrong syntax:

/vscode/vscode-server-insiders/bin/linux-x64/2c73d2651cc525b27fc697b820743098a204ec01-insider/out/vs/workbench/contrib/terminal/browser/media/shellIntegration.fish (line 33): $(...) is not supported. In fish, please use '(string)'.
        set ITEMS $(string split : $VSCODE_ENV_REPLACE)
                  ^
from sourcing file /vscode/vscode-server-insiders/bin/linux-x64/2c73d2651cc525b27fc697b820743098a204ec01-insider/out/vs/workbench/contrib/terminal/browser/media/shellIntegration.fish
        called on line 185 of file /usr/share/fish/config.fish
in function '.' with arguments '/vscode/vscode-server-insiders/bin/linux-x64/2c73d2651cc525b27fc697b820743098a204ec01-insider/out/vs/workbench/contrib/terminal/browser/media/shellIntegration.fish'
        called on line 4 of file ~/.config/fish/conf.d/vscode-integration.fish
from sourcing file ~/.config/fish/conf.d/vscode-integration.fish
        called on line 294 of file /usr/share/fish/config.fish
from sourcing file /usr/share/fish/config.fish
        called during startup
source: Error while reading file '/vscode/vscode-server-insiders/bin/linux-x64/2c73d2651cc525b27fc697b820743098a204ec01-insider/out/vs/workbench/contrib/terminal/browser/media/shellIntegration.fish'

Steps to Reproduce:

1. Have a linux environment with an installed fish-shell (fish 3.1.2 here)
2. Have the shell integration added in your fish configuration:

if status is-interactive
    # Commands to run in interactive sessions can go here
    string match -q "$TERM_PROGRAM" "vscode"
    and . (code --locate-shell-integration-path fish)
end

3. Open Terminal and find syntax issue.

I can confirm the wrong syntax in used file, and I can review/test fixes.

[max06]

Update: Only broken in fish below version 3.4.0 - newer versions got support for the bash syntax for command substitutions.

[Tyriar]

Verified by author as they contributed the fix.