Skip to content

Emmet: add css.color.short setting #116912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

lancewl
Copy link
Contributor

@lancewl lancewl commented Feb 18, 2021

This PR fixes #72594
Depends on microsoft/vscode-emmet-helper#50

@@ -56,5 +56,6 @@
"emmetPreferencesCssMsProperties": "Comma separated CSS properties that get the 'ms' vendor prefix when used in Emmet abbreviation that starts with `-`. Set to empty string to always avoid the 'ms' prefix.",
"emmetPreferencesCssFuzzySearchMinScore": "The minimum score (from 0 to 1) that fuzzy-matched abbreviation should achieve. Lower values may produce many false-positive matches, higher values may reduce possible matches.",
"emmetOptimizeStylesheetParsing": "When set to `false`, the whole file is parsed to determine if current position is valid for expanding Emmet abbreviations. When set to `true`, only the content around the current position in css/scss/less files is parsed.",
"emmetPreferencesOutputReverseAttributes": "If `true`, reverses attribute merging directions when resolving snippets."
"emmetPreferencesOutputReverseAttributes": "If `true`, reverses attribute merging directions when resolving snippets.",
"emmetPreferencesCssColorShort": "If `true`, color values like #ffffff will be shortened to #fff after abbreviation."
Copy link
Contributor

@rzhao271 rzhao271 Feb 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"emmetPreferencesCssColorShort": "If `true`, color values like #ffffff will be shortened to #fff after abbreviation."
"emmetPreferencesCssColorShort": "If `true`, color values like #f will be expanded to #fff instead of #ffffff."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the description!

@rzhao271 rzhao271 added emmet Emmet related issues feature-request Request for new features or functionality hackathon Label reserved for specific events labels Feb 18, 2021
@rzhao271 rzhao271 added this to the February 2021 milestone Feb 18, 2021
@rzhao271 rzhao271 self-assigned this Feb 18, 2021
@rzhao271 rzhao271 merged commit 2bb9fdf into microsoft:main Feb 18, 2021
@lancewl lancewl deleted the emmet-css-color-short-setting branch February 18, 2021 17:15
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
emmet Emmet related issues feature-request Request for new features or functionality hackathon Label reserved for specific events
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emmet: Support css.color.short setting
2 participants