Skip to content

Make error message clearer #121339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2021
Merged

Make error message clearer #121339

merged 2 commits into from
Apr 16, 2021

Conversation

sdegutis
Copy link
Contributor

This PR fixes #121324

@connor4312 connor4312 assigned bpasero and unassigned weinand Apr 15, 2021
bpasero
bpasero requested changes Apr 15, 2021
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically do not hardcode "VS Code" as name, you can use IProductService.nameShort or if services are not accessible, import vs/platform/product/common/product and get the property from there.

@bpasero bpasero added this to the April 2021 milestone Apr 15, 2021
@sdegutis
Copy link
Contributor Author

Figured as much. Will give it another try in a few weeks.

@bpasero bpasero merged commit 59963d0 into microsoft:main Apr 16, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero requested changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
April 2021
Development

Successfully merging this pull request may close these issues.

Warning wording when opening too-large file
3 participants
@sdegutis @bpasero @weinand