Add support for eslintrc.json seti-ui icon

[adaex]

This PR follows the steps from CONTRIBUTING.md to pull in updates from seti-ui, adding an already existing icon for eslintrc.js file to eslintrc.json

jesseweed/seti-ui already supports the icon for eslintrc.json file. View line 554.

Screenshot of preview.html:

[aeschli]

Can you explain how you got to these changes?

I just updated the icon theme with the latest what's in seti-theme: 86bc051

• have the main branches of https://github.com/jesseweed/seti-ui and https://github.com/microsoft/vscode cloned in the same parent folder
• in the seti-ui folder, run npm install and npm run prepublishOnly. This will generate updated icons and fonts.
• in the vscode/extensions/theme-seti folder run npm run update. This will launch the icon theme update script that updates the theme as well as the font based on content in seti-ui.
• to test the icon theme, look at the icon preview as described above.

I updated CONTRIBUTING.md with these clarifications

You migth have to study and correct the update-icon-theme.js. Not sure why it doesn't create a filename rule for eslintrc.json

[ghost]

All CLA requirements met.

[adaex]

@aeschli , In fact, this problem puzzled me at first, but now I seem to find the reason why the eslintrc.json file icon is not generated.

Let me repeat that.

1. In line 52 of the file extensions/json/package.json, we can see that the extensions of jsonc is assigned .jsonc, .eslintrc, .eslintrc.json, etc.

2. In extensions/theme-seti/build/update-icon-theme.js, we can see that preferredDef attempts to assign values through extensions and filenames.

For jsonc, the extensions .jsonc does not exist in seti-ui, so the value of preferredDef is assigned to the icon of .eslintrc.

3. According to the following code, we can find that the file allocation of .eslintrc and .eslintrc.json has been deleted.

If we still don't understand, we can check the logic. Follow the screenshot below to add some code.

Run npm run update, Here is the output:

node ➜ /workspaces/vscode/extensions/theme-seti (eslint-icon ✗) $ npm run update

> [email protected] update /workspaces/vscode/extensions/theme-seti
> node ./build/update-icon-theme.js

Reading from ../../../seti-ui/styles/_fonts/seti.less
lang: jsonc  preferredDef: _eslint
remove the extension association: eslintrc
remove the extension association: eslintrc.json
written ./icons/vs-seti-icon-theme.json
updated ./cgmanifest.json
Updated to jesseweed/seti-ui@2b078f8 (2021-05-05)

We can verify that jsonc is assigned as the _eslint icon, and finally remove the file icon assignment of eslintrc and eslintrc.json.

My current solution is to ignore this part of the operation if the language has been defined in inheritIconFromLanguage.

[aeschli]

Thanks @adaex !