Skip to content

Honor setting show only shortcut keys #136251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2021

Conversation

PEZ
Copy link
Contributor

@PEZ PEZ commented Nov 1, 2021

In the last changes of #126742 we made the setting screencastMode.onlyKeyboardShortcuts stop working. This reinstalls it.

CC: @joaomoreno

@PEZ
Copy link
Contributor Author

PEZ commented Nov 2, 2021

This is still not right. Looking at it.

@PEZ
Copy link
Contributor Author

PEZ commented Nov 2, 2021

Now it works such that:

For screencastMode.onlyKeyboardShortcuts is false => show all keys pressed

ForscreencastMode.onlyKeyboardShortcuts is true, and we have a shortcut command =>

  • Format is keys => Show keys
  • Format is command => Show command title if we have it, otherwise keys (”same" for commandWithGroup)
  • Format is commandAndKeys => Show command + keys if we have a command title, otherwise just keys ("same" for commandWithGroupAndKeys)

What tripped us up was probably the settings semantics talking about shortcut, but in the implementation semantics that is a shortcut with a commandId. (I.e. the first part of a chord for a shortcut command is a shortcut.) I don't know what we should be calling it instead.

@joaomoreno joaomoreno added this to the November 2021 milestone Nov 5, 2021
@joaomoreno joaomoreno merged commit 120ddb6 into microsoft:main Nov 5, 2021
@joaomoreno
Copy link
Member

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants