Added features and fixes to screencast mode #171845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
webarthur
commented
Jan 20, 2023
- Fix annoying arrow key repetition in screencast mode
- Fix label of pressed arrow keys in screencast mode
- Add option to hide single arrow keys pressed in screencast mode
|
@microsoft-github-policy-service agree [company="{your company}"] |
|
@microsoft-github-policy-service agree |
joaomoreno
requested changes
Feb 21, 2023
joaomoreno
requested changes
Feb 23, 2023
Co-authored-by: João Moreno <[email protected]>
|
So will this be merged? :) |
|
Also waiting for that! |
|
I only understood now that the setting is about not showing the commands used to move the text editor cursor. It's not about arrow keys per se... since a user can customize the keyboard shortcuts for the cursor move commands. |
joaomoreno
approved these changes
Mar 9, 2023
aeschli
approved these changes
Mar 9, 2023
|
Maybe its only me, but at least I now get a pop up for each key that I type although I enabled the flag to show only on keyboard shortcuts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.