Fix: Changed bash-syntax to fish-syntax in shellIntegration #181637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm on fish 3.5.1, do you know why it was working for me but not you? |
|
Thanks to you I just noticed my old fish version. I thought I installed it with brew, but I used the debian repo one. Checking the changelog, it looks like fish added support for the bash-syntax in 3.4.0. Which is great, better compatibility to bash-scripts. Testing again locally with both fish versions confirms the changelog: Your working version also works here with the newer fish version. I still think this PR is useful because many repository maintainers haven't updated their packages yet. |
Tyriar
approved these changes
May 9, 2023
alexr00
approved these changes
May 9, 2023
meganrogge
approved these changes
May 9, 2023
|
Great experience, will commit again! 🙇🏼 |
|
@max06 good to hear, we're no experts in fish scripting so this was very helpful! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the regression in the
shellIntegration.fish-script.The used bash-syntax for a command substitution (
$(...)) doesn't work in fish (expects(...)without$).Closes #181634
I wasn't able to find tests for this script. I tested it manually in my insiders instance and I can now see exit status markings again. I'd need further instructions if that's not enough.