Skip to content

Add context key notebookEditorCursorAtLineBoundary #187679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2023
Merged

Add context key notebookEditorCursorAtLineBoundary #187679

merged 1 commit into from
Aug 25, 2023

Conversation

hsfzxjy
Copy link
Contributor

@hsfzxjy hsfzxjy commented Jul 12, 2023

Add context key notebookEditorCursorAtLineBoundary to indicate the cursor position inside a notebook cell editor. Fix #186585.

@hsfzxjy hsfzxjy marked this pull request as draft July 12, 2023 07:16
@hsfzxjy hsfzxjy force-pushed the context-key-notebook-cell-end-of-line branch from 76379d7 to d9c12c8 Compare July 12, 2023 07:18
@hsfzxjy hsfzxjy marked this pull request as ready for review July 12, 2023 07:18
@hsfzxjy hsfzxjy force-pushed the context-key-notebook-cell-end-of-line branch 6 times, most recently from ab52167 to e28033c Compare July 19, 2023 06:10
@hsfzxjy hsfzxjy force-pushed the context-key-notebook-cell-end-of-line branch 2 times, most recently from 894cd2a to 53a2dad Compare August 9, 2023 12:20
@rebornix rebornix added this to the August 2023 milestone Aug 23, 2023
@hsfzxjy hsfzxjy force-pushed the context-key-notebook-cell-end-of-line branch 3 times, most recently from e330df2 to 386c98f Compare August 23, 2023 15:25
@hsfzxjy hsfzxjy force-pushed the context-key-notebook-cell-end-of-line branch from 386c98f to 2c38c39 Compare August 24, 2023 07:28
rebornix
rebornix approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@rebornix rebornix enabled auto-merge (squash) August 25, 2023 18:58
@rebornix rebornix merged commit 29661cb into microsoft:main Aug 25, 2023
@hsfzxjy hsfzxjy deleted the context-key-notebook-cell-end-of-line branch August 26, 2023 01:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

@meganrogge meganrogge meganrogge approved these changes

Assignees

@rebornix rebornix

Labels
None yet
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.

Add Context Key for when cursor is at end of line in cell
3 participants
@hsfzxjy @rebornix @meganrogge