Skip to content

#245665 fix early task exit with empty promptString input #246834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

johnscollins98
Copy link
Contributor

@johnscollins98 johnscollins98 commented Apr 17, 2025

address issue #245665

tested with the following tasks.json file:

{
  "version": "2.0.0",
  "tasks": [
    {
      "command": "echo",
      "label": "echo",
      "args": [
        "${input:test1}",
        "${input:test2}"
      ]
    }
  ],
  "inputs": [
    {
      "id": "test1",
      "type": "promptString",
      "default": "",
      "description": "test1"
    },
    {
      "id": "test2",
      "type": "promptString",
      "default": "",
      "description": "test2"
    }
  ]
}

entering empty strings into the prompts, before my change it ends early after test1 after it goes all the way through to echo both inputs

Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meganrogge meganrogge added this to the April 2025 milestone Apr 17, 2025
@meganrogge meganrogge enabled auto-merge (squash) April 21, 2025 13:48
@meganrogge meganrogge merged commit 6167324 into microsoft:main Apr 21, 2025
7 checks passed
@johnscollins98 johnscollins98 deleted the fix-empty-prompt-string branch April 21, 2025 16:49
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants