Skip to content

Test on Java 21 #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Test on Java 21 #1242

wants to merge 1 commit into from

Conversation

jyemin
Copy link
Collaborator

@jyemin jyemin commented Nov 2, 2023

  • Add JDK 21 to Gradle configuration
  • Add JDK 21 to the test matrix
  • Replace JDK 17 with JDK 21 for tasks that are ony run using latest JDK
  • Update Mockito dependency

JAVA-5164

@jyemin jyemin self-assigned this Nov 2, 2023
@@ -256,8 +256,7 @@ configure(javaCodeCheckedProjects) {
testImplementation platform('org.spockframework:spock-bom:2.1-groovy-3.0')
testImplementation 'org.spockframework:spock-core'
testImplementation 'org.spockframework:spock-junit4'
testImplementation("org.mockito:mockito-core:3.8.0")
testImplementation("org.mockito:mockito-inline:3.8.0")
testImplementation("org.mockito:mockito-core:5.6.0")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of the 5.3.0 release. mockito-inline is no longer published. It's functionality is now part of mockito-core

@jyemin
Copy link
Collaborator Author

jyemin commented Nov 2, 2023

Hmm, some tests are failing. I will check later.

@jyemin
Copy link
Collaborator Author

jyemin commented Nov 2, 2023

Oh, all the Java 8 tests are now failing. Moving to draft... :(

@jyemin jyemin marked this pull request as draft November 2, 2023 17:06
@jyemin
Copy link
Collaborator Author

jyemin commented Nov 2, 2023

Status: The mockito library does not have a release available that supports both Java 8 and Java 21.

  • 4.11 supports from 8 to 20
  • 5.0+ supports from 11 to 21

Parking this PR while we determine next steps. If we drop Java 8 support then we can proceed with this PR.

* Add JDK 21 to Gradle configuration
* Add JDK 21 to the test matrix
* Replace JDK 17 with JDK 21 for tasks that are ony run using latest JDK
* Update Mockito dependency

JAVA-5164
@jyemin jyemin force-pushed the j5164 branch 2 times, most recently from f3372b2 to 7cda7e0 Compare November 2, 2023 18:25
@stIncMale stIncMale mentioned this pull request Mar 4, 2024
@rozza rozza closed this Mar 12, 2024
@rozza
Copy link
Member

rozza commented Mar 12, 2024

Closing as #1326 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants