Skip to content

Commit 984ae30

Browse files
cjihrigtargos
authored andcommitted
build: make --without-report a no-op
This commit makes the configure --without-report flag a no-op. This commit also updates a test that depends on the report CLI flags being conditionally present. PR-URL: #32242 Fixes: #26293 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
1 parent 70eaba1 commit 984ae30

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

configure.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -532,12 +532,12 @@
532532
dest='without_npm',
533533
help='do not install the bundled npm (package manager)')
534534

535+
# Dummy option for backwards compatibility
535536
parser.add_option('--without-report',
536537
action='store_true',
537-
dest='without_report',
538-
help='build without report')
538+
dest='unused_without_report',
539+
help=optparse.SUPPRESS_HELP)
539540

540-
# Dummy option for backwards compatibility
541541
parser.add_option('--with-snapshot',
542542
action='store_true',
543543
dest='unused_with_snapshot',
@@ -1004,7 +1004,6 @@ def configure_node(o):
10041004
o['variables']['OS'] = 'android'
10051005
o['variables']['node_prefix'] = options.prefix
10061006
o['variables']['node_install_npm'] = b(not options.without_npm)
1007-
o['variables']['node_report'] = b(not options.without_report)
10081007
o['variables']['debug_node'] = b(options.debug_node)
10091008
o['default_configuration'] = 'Debug' if options.debug else 'Release'
10101009

test/parallel/test-process-env-allowed-flags-are-documented.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,6 @@ const conditionalOpts = [
5959
filter: (opt) => opt === '--icu-data-dir' },
6060
{ include: process.features.inspector,
6161
filter: (opt) => opt.startsWith('--inspect') || opt === '--debug-port' },
62-
{ include: process.config.variables.node_report,
63-
filter: (opt) => opt.includes('-report') },
6462
];
6563
documented.forEach((opt) => {
6664
conditionalOpts.forEach(({ include, filter }) => {

0 commit comments

Comments
 (0)