Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fff25a0714576f7f92c73111bab1c63219812da0
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8d6b74d3474080bd29dd698f55e88aba17c6a69e
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Nov 17, 2020

  1. build: enable ASLR (PIE) on OS X 

    After conducting several benchmarks, I noticed performance losses of
5-10%. As OS X is not a performance critical platform, as already
mentioned by @bnoordhuis, I have removed the -no_pie flag at least for
this platform. I'd love to enable PIE for other platforms if the 5-10%
speed loss is not too high. I would be happy to hear your opinion on
this.

Refs: #33425

PR-URL: #35704
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
    @woodfairy @nodejs-github-bot
    woodfairy authored and nodejs-github-bot committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    8d6b74d View commit details
    Browse the repository at this point in the history
Loading