sk-usbhid: improved PIN error handling #329
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To lookup a discoverable SSH credential, some form of user verification is required. If the device supports a PIN, return a suitable error.
Define an error to indicate to the user that a PIN is required but not set on the authenticator. Joint work with @martelletto.
To use a verify-required credential, some form of UV has to be configured. If the device supports a PIN and has no form of UV set, return SSH_SK_ERR_PIN_NOT_SET. Joint work with @martelletto.
No-op if PIN has already been set. Joint work with @martelletto.
On a SSH_ERR_DEVICE_PIN_NOT_SET error, assist user in setting a PIN. Joint work with @martelletto.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is a continuation of #310; marked as draft until #310 is merged/closed.For
verify-requiredandresidentoptions,ssh-keygenalways prompts for a PIN. If the authenticator does not have a PIN set, the user is presented with an"invalid format"error message.Instead of preemptively asking for a PIN, determine whether it's required by examining the authenticator's return value. If a PIN is required but not set, optionally set a new PIN. Otherwise, print a more informative error message to the user.